Ping again.
On Sun, 13 Apr 2025 at 22:05, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>
> On Thu, 31 Oct 2024 at 21:15, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>>
>> On Tue, 24 Sept 2024 at 22:56, Magnus Hagander <magnus@hagander.net> wrote:
>> > Well, that's just plain wrong :) The README is in the archives repo, it has nothing to do with commitfests...
>>
>> Fixed
>
>
> Ping ;)
Sorry about the ridiculous slowness in this one :/
I've applied patch 2, it'll be included in my next push (it's sitting behind another thing that I'm currently testing, but soon).
For patch 1, there are a few things still.
The change in schema.sql to add subscriber_access should surely be a separate commit, it's not part of adding a README file. (in fact, many thing are not adding a README file). So I'll separate thato ne out right away. That said, this one is also caught in the limbo between some things being as migrations and some things not, that reall needs to get cleaned up :/ Celestin worked on that at some point, I think, and I need to get back to properly reviewing that.
I'm not sure how much sense it makes to load data from schema.sql. Wouldn't it be better with a dev_data entr?
Also, I don't think removing text search configuration completely from a dev install is the right way to go. All of this is definitely part of the system and if nothing else one would want to make not to accidentally *break* it in dev, thus they are needed.
The example settings file I think would also need the CSRF_COOKIE_SECURE and SESSION_COOKIE_SECURE flags, no?
The comment for PUBLIC_ARCHIVES is incorrect, as it's not just about the API, it's about access to the archives at all.
Why is uwsgi in requirements.txt and not in the apt-get install prerequisite? That would make it much easier :) (same thing would go for the other requirements added of course, but those do make more sense to keep around)
And if one follows the instructions, the whole run_dev script shouldn't be needed at all since you now the virtual env is installed in env?
And finally why do we need to comment out things in the sample file? it's just a sample file after all?
//Magnus
