Re: Typos in logical decoding - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Typos in logical decoding
Date
Msg-id CABUevEzLcPuTkR57XPyNZ0d-YKrK2YKnjC+Wv_esXue2FJ_fXQ@mail.gmail.com
Whole thread Raw
In response to Typos in logical decoding  (Antonin Houska <ah@cybertec.at>)
List pgsql-hackers


On Mon, Jul 18, 2016 at 11:00 AM, Antonin Houska <ah@cybertec.at> wrote:
While reading the logical decoding code I noticed a few supposedly mistyped
comments, see the diff below.

Applied, thanks.

 
Besides that, output_plugin_options argument of CreateInitDecodingContext
function is unused, and the function passes NIL to the corresponding argument
of StartupDecodingContext. This looks to me like a thinko.

I agree it looks like a thinko, and AFAICT all internal uses pass NIL there anyway so it makes no difference on those. I'll wait for someone more familiar with that code to comment though :) 

--

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Regression tests vs existing users in an installation
Next
From: Tom Lane
Date:
Subject: Re: Regression tests vs existing users in an installation