Re: Gotchas about pg_verify_checksums - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Gotchas about pg_verify_checksums
Date
Msg-id CABUevEypFu4qisSwQ=xGiTKMvB28yRd+84n1sdZubjQ_s9ktTA@mail.gmail.com
Whole thread Raw
In response to Re: Gotchas about pg_verify_checksums  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Gotchas about pg_verify_checksums
List pgsql-hackers


On Sun, Apr 15, 2018 at 9:49 AM, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 15 Apr 2018, at 09:36, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Apr 10, 2018 at 10:27:19PM +0200, Daniel Gustafsson wrote:
>> Thinking more on this, I don’t think the -f option should be in the tool until
>> we have the ability to turn on/off checksums.  Since checksums are always on,
>> or always off, -f is at best confusing IMO.  The attached patch removes -f,
>> when we can turn checksums on/off we can rethink how -f should behave.
>
> You have forgotten to update the list of arguments in getopt().

Doh. Thanks, fixed in attached patch.

I have applied this patch along with the documentation patch from Michael.

Thanks! 

--

pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: Re: pgsql: Revert "Allow on-line enabling and disabling of datachecksums"
Next
From: Magnus Hagander
Date:
Subject: Re: pgsql: Revert "Allow on-line enabling and disabling of data checksums"