Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests
Date
Msg-id CABUevEyJLA7y_cNr6xhd=CWG4yZiSMBi8TbzN3Tfu8ZdWA24vg@mail.gmail.com
Whole thread Raw
In response to Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view 
On Sat, Jan 29, 2022 at 9:44 PM Andres Freund <andres@anarazel.de> wrote:
>
> On 2022-01-17 10:06:56 -0800, Andres Freund wrote:
> > Yes, that's what I was suggesting. I wasn't thinking of using a static var,
> > but putting it in StreamCtl. Note that what pgwin32_waitforsinglesocket()
> > is doing doesn't protect against the problem referenced above, because it
> > still is reset by WSAEventSelect.
>
> Do we are about breaking StreamCtl ABI? I don't think so?

I would say no. It's an internal API and it's not like pg_basebackup
can load plugins.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included
Next
From: Magnus Hagander
Date:
Subject: Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests