Re: [PATCH] Fix CSRF verification in /admin/mergeorg/ and /admin/purge/ - Mailing list pgsql-www

From Magnus Hagander
Subject Re: [PATCH] Fix CSRF verification in /admin/mergeorg/ and /admin/purge/
Date
Msg-id CABUevEyGeMBzyoO0j9qtGMkEnc1MVKTXOP19s+8MGvL9AutvEQ@mail.gmail.com
Whole thread Raw
In response to [PATCH] Fix CSRF verification in /admin/mergeorg/ and /admin/purge/  (Marti Raudsepp <marti@juffo.org>)
List pgsql-www
On Wed, Nov 7, 2012 at 9:28 PM, Marti Raudsepp <marti@juffo.org> wrote:
> It's clear now why CSRF didn't work on these pages: the csrf_token
> templatetag requires rendering the template with a RequestContext.
>
> I went through all code using render_to_response() without
> RequestContext/NavContext and made sure that they don't process POST
> data. I skimmed through the grep last time, but apparently I wasn't
> very attentive.
>
> I also permitted POST requests to /search/ again. These aren't sent by
> the site itself, but it was allowed before, maybe for a reason.

Looks reasonable - thanks, applied!

--Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/



pgsql-www by date:

Previous
From: Marti Raudsepp
Date:
Subject: [PATCH] Fix CSRF verification on /api/varnish/purge & misc
Next
From: Magnus Hagander
Date:
Subject: Re: [PATCH] Fix CSRF verification on /api/varnish/purge & misc