Re: [DOCS] Moving tablespaces - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [DOCS] Moving tablespaces
Date
Msg-id CABUevExQ=rFLxYXaivKR1ue_yv4BAuNy6z8fDn_3zqa3coZiFQ@mail.gmail.com
Whole thread Raw
In response to Re: [DOCS] Moving tablespaces  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [DOCS] Moving tablespaces
List pgsql-hackers
On Tue, Dec 6, 2011 at 16:17, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Throwing an error seems a lot more safe in this case than just
>> returning NULL. Since it's a situtation that really shouldn't happen.
>> Maybe an assert, but I think a regular ereport(ERROR) would be the
>> best.
>
> Not an assert, since it's trivially user-triggerable.

Right.

There is some nice precedent in the CREATE TABLESPACE command (though
dependent on HAVE_SYMLINK and not HAVE_READLINK), so I'm just going to
copy the error message from there.


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [DOCS] Moving tablespaces
Next
From: Tom Lane
Date:
Subject: Re: pull_up_simple_subquery