Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] pg_basebackups and slots - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [HACKERS] pg_basebackups and slots
Date
Msg-id CABUevExPJPrgKjZos0xwdsV+BmWUscPU=HqPEkxLFXy_gn8nbA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] pg_basebackups and slots  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] pg_basebackups and slots  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Tree view


On Wed, Jan 4, 2017 at 3:32 PM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
This patch looks reasonable to me.

Attached is a top-up patch with a few small fixups.

I suggest to wait for the resolution of the "Replication/backup
defaults" thread.  I would not want to be in a situation where users who
have not been trained to use replication slots now have yet another
restart-only parameter to set before they can take a backup.


Thanks for the review and the top-up patch. I've applied it and pushed.

I just realized I missed crediting you with the review and the top-up in the commit message. My apologies for this. 

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Support for pg_receivexlog --format=plain|tar
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Implement targetlist SRFs using ROWS FROM() (wasChanged SRF in targetlist handling)