pg_upgrade dead code for pre-8.4 versions - Mailing list pgsql-hackers

From Magnus Hagander
Subject pg_upgrade dead code for pre-8.4 versions
Date
Msg-id CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493MJt-x6sppbUxA@mail.gmail.com
Whole thread Raw
Responses Re: pg_upgrade dead code for pre-8.4 versions  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
pg_upgrade documentation says it supports upgrades from 8.4 and newer.

But there is code in there that makes a check and differs pre-8.4 from 8.4-or-newer.

ISTM that code could be cleaned out, because it should be dead based on the initial check that we are upgrading from 8.4 or later?

This appears to be:
* The code in the analyze script (see a follow-up email on this), which actually tries to generate a vacuum script if it's a pre-8.4 without visibility map
* The file copy code in relfilenode.c that copies vm and fsm files only from 8.4 and up (which should now be always)

Or am I misreading something?

//Magnus

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: Masahiro Ikeda
Date:
Subject: Re: Add session statistics to pg_stat_database