Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Allow background workers to bypass datallowconn - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: Allow background workers to bypass datallowconn
Date
Msg-id CABUevEwsbsXSvE=p_ZPgzOptaeM3JmSbE730z=ZHi68v6tpL+Q@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Allow background workers to bypass datallowconn  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-committers
Tree view
On Thu, Apr 5, 2018 at 7:11 PM, Teodor Sigaev <teodor@sigaev.ru> wrote:
Something goes wrong

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2018-04-05 17%3A07%3A19

Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/test/modules/worker_spi/worker_spi.c: In function ‘worker_spi_main’:
Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/test/modules/worker_spi/worker_spi.c:182:2: error: too few arguments to function ‘BackgroundWorkerInitializeConnection’
Apr 05 13:09:08   BackgroundWorkerInitializeConnection("postgres", NULL);
Apr 05 13:09:08   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Apr 05 13:09:08 In file included from /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/test/modules/worker_spi/worker_spi.c:27:0:
Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/include/postmaster/bgworker.h:143:13: note: declared here
Apr 05 13:09:08  extern void BackgroundWorkerInitializeConnection(const char *dbname, const char *username, uint32 flags);
Apr 05 13:09:08              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Apr 05 13:09:08 <builtin>: recipe for target 'worker_spi.o' failed


Gah, I didn't run those tests.

Thanks, fix pushed. 

--

pgsql-committers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: pgsql: Allow background workers to bypass datallowconn
Next
From: Magnus Hagander
Date:
Subject: pgsql: Fix worker_spi for new parameter to initialize connection