Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Allow pg_basebackup to stream transaction log in tar mode - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: Allow pg_basebackup to stream transaction log in tar mode
Date
Msg-id CABUevEwkBX91Rbn8_qkT+adpe0Dge+-fFpVB1Vkajp3v9PBtgg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Allow pg_basebackup to stream transaction log in tar mode  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-committers
Tree view
On Mon, Oct 24, 2016 at 2:58 PM, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:
I have following warning while compiling with clang.

walmethods.c:437:9: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
                if (r < 0)
                    ~ ^ ~
1 warning generated.

It seems that 'r' should be 'ssize_t' instead of 'size_t'.


Yup. The result from tar_write() is ssize_t so it definitely should be.

Thanks, I've applied a fix.

//Magnus

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Translation updates
Next
From: Magnus Hagander
Date:
Subject: pgsql: Use ssize_t where signed results can happen