On 6/8/20 11:23 AM, Dave Page wrote: > > > On Mon, Jun 8, 2020 at 4:14 PM Jonathan S. Katz <jkatz@postgresql.org > <mailto:jkatz@postgresql.org>> wrote: > > On 6/8/20 10:55 AM, Dave Page wrote: > > Here's an updated patch with the changes suggested below, as well as > > similar simplification for the Debian/Ubuntu pages. > > Overall LGTM. Given it's in a "<pre>" block, would we be able to use > newlines (\n) instead of "<br />"? I'd like to avoid introducing more > <br /> if possible, but if that's the way it goes, so be it. > > > Yes, yes we can. Fixed in my tree, along with the pre-existing ones. > > > > Certainly a nice improvement. Thanks! > > > Yw :-)
Awesome. If said fixes do work, then I'm a +1 for adding it.
+1 in general. The one thing about the implementation that irks me a bit is that you picked id=script, because when I read it my mind just automatically thinks <script>. But that's not a big thing :)
If you want to make it even more fancy, add a button that copies it to the clipboard and does so without including the comments?
I wonder if it would make sense to still keep the client and server setups in separate boxes, so you can easily just select "all for client"? That is, one step that does reporpm + client, and a separate step that has all the stuff for server?
Or if we think that's too complicated, then I suggest we just zap the part about the server being optional and merge it all into a single set, where you dnf/yum install both server and client at the same time. Having a comment in a copy/paste script that says "the rest is optional" just feels weird when the whole point of the exercise is to make it more easy to copy/paste.
I had a note for myself on the debian side as well, to make it more copy/pastetable :) Thanks for taking care of that one!
