Re: Somewhat excessive version checks - Mailing list pgadmin-hackers

From Magnus Hagander
Subject Re: Somewhat excessive version checks
Date
Msg-id CABUevEw2Y20sJcQ0r7s6Gi72jsVJaKWitsm3yRkF5Phmfu61pg@mail.gmail.com
Whole thread Raw
In response to Re: Somewhat excessive version checks  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
On Tue, Jan 12, 2021 at 5:59 AM Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
>
>
>
> On Tue, Jan 12, 2021 at 3:36 AM Magnus Hagander <magnus@hagander.net> wrote:
>>
>> Hi!
>>
>> If I read the code correctly, pgadmin will (unless turned off) hit the
>> website to check the version.json file for updates *every time it
>> starts*.
>>
>> Wouldn't it make sense to rate limit that to checking say once per 24
>> hours maximum? Or even 48?
>>
>> It seems nobody needs the update *that* quickly, and AFAICT it does
>> call out to make that check synchronously on startup which means the
>> user is waiting.
>>
> Agreed, we should have some mechanism in place to limit the server hit, maybe an asynchronous call from the client
whileloading.
 


Seems async front he server would be a better choice there, if you
have some ways for that? Otherwise, how to determine which user to
trust when storing the result etc?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/



pgadmin-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Somewhat excessive version checks
Next
From: Pradip Parkale
Date:
Subject: Re: [pgAdmin][RM5912]: Added support for Logical Replication.