Re: pgstattuple: Use streaming read API in pgstatindex functions - Mailing list pgsql-hackers

From Xuneng Zhou
Subject Re: pgstattuple: Use streaming read API in pgstatindex functions
Date
Msg-id CABPTF7Ue9C3YUS8ggpOJS8RMCNyqygsYsvJfnvmTqY7Ua2pTQg@mail.gmail.com
Whole thread Raw
In response to Re: pgstattuple: Use streaming read API in pgstatindex functions  (wenhui qiu <qiuwenhuifx@gmail.com>)
List pgsql-hackers
Hi Wenhui,

Thanks for looking into this.

On Mon, Oct 13, 2025 at 5:41 PM wenhui qiu <qiuwenhuifx@gmail.com> wrote:
>
> Hi Xuneng Zhou
>
>
> > - /* Unlock and release buffer */
> > - LockBuffer(buffer, BUFFER_LOCK_UNLOCK);
> > - ReleaseBuffer(buffer);
> > + UnlockReleaseBuffer(buffer);
> >  }
>  Thanks for your patch! Just to nitpick a bit — I think this comment is worth keeping, even though the function name
alreadyconveys its meaning. 
>

It makes sense. I'll keep it.

Best,
Xuneng



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Adding basic NUMA awareness
Next
From: Álvaro Herrera
Date:
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options