Re: [ pg_ctl ] Review Request for Adding Pre-check User Script Feature - Mailing list pgsql-hackers

From Zaid Shabbir
Subject Re: [ pg_ctl ] Review Request for Adding Pre-check User Script Feature
Date
Msg-id CABCJe_Ut2V7Lxq81exCcNBFiLV4Tc_2PP3vN0uBXQKLqUUFcvQ@mail.gmail.com
Whole thread Raw
In response to [ pg_ctl ] Review Request for Adding Pre-check User Script Feature  (김명준 <rayjun0525@gmail.com>)
List pgsql-hackers
Hello,

Can you briefly explain what’s the issues you are going through the patch?


On Tue, 16 Jul 2024 at 11:40 AM, 김명준 <rayjun0525@gmail.com> wrote:

Hello,

I have been considering adding a user script that performs pre-checks before executing the start, stop, and restart operations in pg_ctl. I believe it is necessary for pg_ctl to support an extension that can prevent various issues that might occur when using start and stop. To this end, I have sought a way for users to define and use their own logic. The existing behavior remains unchanged, and the feature can be used optionally when needed.

The verification of the code was carried out using the methods described below, and I would like to request additional opinions or feedback. Tests were conducted using make check and through direct testing under various scenarios. As this is my first contribution, there might be aspects I missed or incorrectly designed.

I would appreciate it if you could review this.

Thank you.


Myoungjun Kim / South Korea

pgsql-hackers by date:

Previous
From: 김명준
Date:
Subject: [ pg_ctl ] Review Request for Adding Pre-check User Script Feature
Next
From: Michael Paquier
Date:
Subject: Re: Direct SSL connection and ALPN loose ends