Re: Error with index on unlogged table - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Error with index on unlogged table
Date
Msg-id CAB7nPqTdVSYDPmCTO0mYHuDrQKfHi5Ef+p5nkEdGK3WjCBNO1A@mail.gmail.com
Whole thread Raw
In response to Re: Error with index on unlogged table  (Andres Freund <andres@anarazel.de>)
Responses Re: Error with index on unlogged table  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Dec 8, 2015 at 9:57 PM, Andres Freund <andres@anarazel.de> wrote:
> For me the attached, preliminary, patch, fixes the problem in master;
> previous branches ought to look mostly similar, except the flush moved
> to RestoreBackupBlockContents/RestoreBackupBlock.
> Does anybody have a better idea? Suitable for the back-branches?

Not really I am afraid..

> I'm kinda wondering if it wouldn't have been better to go through shared
> buffers in ResetUnloggedRelationsInDbspaceDir() instead of using
> copy_file().

For deployment with large shared_buffers settings, wouldn't that be
actually more costly than the current way of doing? We would need to
go through all the buffers at least once and look for the INIT_FORKNUM
present to flush them.
-- 
Michael



pgsql-hackers by date:

Previous
From: Sandeep Thakkar
Date:
Subject: Re: Include ppc64le build type for back branches
Next
From: Andres Freund
Date:
Subject: Re: Error with index on unlogged table