Re: pg_dump gets attributes from tables in extensions - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_dump gets attributes from tables in extensions
Date
Msg-id CAB7nPqTStdWB_p7sxwLBGwPvHzsvfwysN4PTCw9LFjA_mxEyxQ@mail.gmail.com
Whole thread
In response to Re: pg_dump gets attributes from tables in extensions  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: pg_dump gets attributes from tables in extensions
List pgsql-hackers


On Wed, Feb 25, 2015 at 10:30 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
Michael Paquier wrote:
> On Tue, Feb 24, 2015 at 11:55 PM, Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:

> > Maybe something in src/test/modules could keep these files so that
> > pg_dump can be tested.  Is anybody interested in doing that?
>
> For the patch to fix data dump of extensions that contain tables with FK I
> have implemented a test case in src/test/modules as I didn't want to look
> at postgis stuff to reproduce the failure, last version is here:
> http://www.postgresql.org/message-id/CAB7nPqQRjHHmNMcGB0eCVZ2PTMNCmFD+1htLOoxRQjMzgtSetQ@mail.gmail.com

That looks interesting -- I don't recall seeing it.  Does it support
more doing than one extension?  If so, we could certainly integrate it.

It uses TAP tests to kick pg_dump commands, and I haven't added any logic for having more than one extension installed within a single test if that is what you mean, but I assume that we could pass to prove_check a variable able to install multiple paths and install their content. For now though what I have done is adding one line to prove_check to install the content of current directory to be able to run TAP tests with one extension.
--
Michael

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Partitioning WIP patch (was: Partitioning: issues/ideas)
Next
From: Alvaro Herrera
Date:
Subject: Re: pg_dump gets attributes from tables in extensions