Re: Better detail logging for password auth failures - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Better detail logging for password auth failures
Date
Msg-id CAB7nPqTNbTCLLcnf5-f9U76dhXMXmpdm9UYg6OXCDKrVbsm56A@mail.gmail.com
Whole thread Raw
In response to Better detail logging for password auth failures  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Dec 30, 2015 at 1:07 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> We often tell people to look in the postmaster log for more information
> about authentication problems; but an off-list question prompted me to
> notice that many of the common authentication failure cases don't actually
> get any useful commentary in the log.  The attached proposed patch
> remedies this by adding specific log detail messages for all the
> non-out-of-memory cases processed by md5_crypt_verify().  Essentially,
> this is just covering cases that I omitted to cover in commit 64e43c59,
> for reasons that no longer seem very good to me.
>
> Any objections?

Not really. +1. And the patch looks good.
-- 
Michael



pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Patch: fix lock contention for HASHHDR.mutex
Next
From: Andres Freund
Date:
Subject: Re: Better detail logging for password auth failures