Re: 9.5 BLOCKER: regrole and regnamespace and quotes - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: 9.5 BLOCKER: regrole and regnamespace and quotes
Date
Msg-id CAB7nPqTCTXPwyiztJvoRRJuN+uNcLKfN=jKW6cU9YowhE3taQw@mail.gmail.com
Whole thread Raw
In response to Re: 9.5 BLOCKER: regrole and regnamespace and quotes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Jan 4, 2016 at 3:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> Attached is an updated patch which passes
>> check-world in my environment.
>
> Pushed with trivial cosmetic changes to the code, and slightly more
> extensive work on the regression test cases.
>
> It strikes me that there might be an argument for returning NULL
> rather than raising an error for to_regrole('foo.bar') and
> to_regnamespace('foo.bar').  On the other hand, input-syntax issues
> result in errors for the other to_reg* functions, so it might
> be fine as-is.  In any case, relaxing the error rather than adding
> one is much easier to justify as a future change, so I left it
> as Jim/Michael had it for the moment.

Thanks!
-- 
Michael



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: 9.5 BLOCKER: regrole and regnamespace and quotes
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Further tweaking of print_aligned_vertical().