Re: ALTER TABLE .. ADD PRIMARY KEY .. USING INDEX has dump-restore hazard - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: ALTER TABLE .. ADD PRIMARY KEY .. USING INDEX has dump-restore hazard
Date
Msg-id CAB7nPqT8BM7Fep2jJM_6Z5Xug-psv77+adYVWjHSW4NB3EEYpg@mail.gmail.com
Whole thread Raw
In response to Re: ALTER TABLE .. ADD PRIMARY KEY .. USING INDEX has dump-restore hazard  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Wed, Jul 22, 2015 at 9:34 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Jul 22, 2015 at 1:23 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> Notice that the collation specifier is gone.  Oops.
>
> As it is not possible to specify directly a constraint for a PRIMARY
> KEY expression, what about switching dumpConstraint to have it use
> first a CREATE INDEX query with the collation and then use ALTER TABLE
> to attach the constraint to it? I am noticing that we already fetch
> the index definition in indxinfo via pg_get_indexdef. Thoughts?

And poking at that I have finished with the attached that adds a
CREATE INDEX query before ALTER TABLE ADD CONSTRAINT, to which a USING
INDEX is appended. Storage options as well as building the column list
becomes unnecessary because indexdef already provides everything what
is needed, so this patch makes dump rely more on what is on
backend-side.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: "make check" changes have caused buildfarm deterioration.
Next
From: Noah Misch
Date:
Subject: Re: Alpha2/Beta1