Postgres Pro
Downloads
Home   >   mailing lists

Re: XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine
Date
Msg-id CAB7nPqT7g-myOi9rmK4yY-gw90iV=2BTmO2dORKJJp2cxapnYQ@mail.gmail.com
Whole thread Raw
In response to Re: XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
Tree view


On Fri, Dec 5, 2014 at 7:12 PM, Heikki Linnakangas <hlinnakangas@vmware.com> wrote:
On 12/05/2014 04:54 AM, Michael Paquier wrote:
Hi all,

While reading the code in this area this morning, I noticed that
wal_log_hints and track_commit_timestamp are not mentioned in the desc
routine of XLOG_CHANGE_PARAMETER. Also, it is not mentioned in
postgresql.conf.sample that a value update of wal_log_hints requires a
system restart.

In order to fix those things, attached are two patches:
- patch 1 should be applied back to 9.4 where wal_log_hints has been added

 You got the wal_level and wal_log_hints strings backwards:
Oops. Thanks for double-checking.
--
Michael

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Review of GetUserId() Usage
Next
From: Robert Haas
Date:
Subject: Re: advance local xmin more aggressively