Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Merge the various forms of transaction commit & abort records. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Merge the various forms of transaction commit & abort records.
Date
Msg-id CAB7nPqT6BO1cCn+sAyDByBxA4EKZNAiPi2mFJ=ANeZmnmewRyg@mail.gmail.com
Whole thread Raw
In response to pgsql: Merge the various forms of transaction commit & abort records.  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Merge the various forms of transaction commit & abort records.  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Tree view 
On Mon, Mar 16, 2015 at 1:38 AM, Andres Freund <andres@anarazel.de> wrote:
> Merge the various forms of transaction commit & abort records.

Coverity is complaining about the following block of code:
+       xact_info = XLogRecGetInfo(record) & XLOG_XACT_COMMIT;
+
+       if (xact_info != XLOG_XACT_COMMIT &&
+               xact_info != XLOG_XACT_COMMIT_PREPARED)
                return false;

Instead of XLOG_XACT_COMMIT, shouldn't this function use XLOG_XACT_OPMASK?
--
Michael

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: to_char: revert cc0d90b73b2e6dd2f301d46818a7265742c41a14
Next
From: Robert Haas
Date:
Subject: pgsql: Remove ill-advised pre-check for DSM segment exhaustion.