Re: [HACKERS] Refactoring of replication commands using printsimple - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Refactoring of replication commands using printsimple
Date
Msg-id CAB7nPqT2K4XFT1JgqufFBjsOc-NUKXg5qBDucHPMbk6Xi1kYaA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Refactoring of replication commands using printsimple  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Refactoring of replication commands using printsimple
List pgsql-hackers
On Tue, Jan 31, 2017 at 11:59 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> Sorry, I have a little more nitpicking.

Thanks for the input.

> How about having
> printsimple() use pq_sendcountedtext() instead of pq_sendint()
> followed by pq_sendbytes(), as it does for TEXTOID?
>
> Other than that, this looks fine to me now.

pq_sendcountedtext() does some encoding conversion, which is why I
haven't used because we deal only with integers in this patch... Now
if you wish to switch to that I have really no arguments against.
-- 
Michael

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] sequence data type
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions