Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Add pg_size_bytes() to parse human-readable size strings. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Add pg_size_bytes() to parse human-readable size strings.
Date
Msg-id CAB7nPqSzz-RJVA_CE_c2_UDEHyphqXuRb1sOKWPEWnoiZTpzmQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add pg_size_bytes() to parse human-readable size strings.  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: pgsql: Add pg_size_bytes() to parse human-readable size strings.  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-committers
Tree view 
On Sat, Feb 20, 2016 at 7:17 PM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
> On 20 February 2016 at 10:12, Michael Paquier <michael.paquier@gmail.com> wrote:
>> Happy first commit.
>
> Arg. Not so much.
>
> Looks like I broke something -- looking into it now :-(

The terabyte conversion is at fault:
Expected:
!  -1tb      |    -1099511627776
Result:
!  -1tb      |            -1

+       else if (pg_strcasecmp(strptr, "gb") == 0)
+           multiplier = 1024 * 1024 * 1024;
+       else if (pg_strcasecmp(strptr, "tb") == 0)
+           multiplier = 1024 * 1024 * 1024 * 1024L;
Why adding an 'L' here?
--
Michael

pgsql-committers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: pgsql: Add pg_size_bytes() to parse human-readable size strings.
Next
From: Dean Rasheed
Date:
Subject: Re: pgsql: Add pg_size_bytes() to parse human-readable size strings.