Re: forward vs backward slashes in msvc build code - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: forward vs backward slashes in msvc build code
Date
Msg-id CAB7nPqSw1kqDm4uCfwkPdRXa1LBYJkiKumgZxm9vqM6rNMxejg@mail.gmail.com
Whole thread Raw
In response to Re: forward vs backward slashes in msvc build code  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: forward vs backward slashes in msvc build code
List pgsql-hackers
On Fri, Mar 13, 2015 at 6:04 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Fri, Mar 13, 2015 at 6:20 AM, Alvaro Herrera wrote:
>> Peter Eisentraut wrote:
>>> This is contrib/chkpass not finding the crypt symbol, which is
>>> presumably in some library.  But I can't see how it would normally find
>>> it, without my patch.
>>
>> It seems crypt is provided by libpgport.  So chkpass should be mentioned
>> in @contrib_uselibpgport, but isn't.  Maybe the fix is just to add it
>> there?
>
> I had a closer look at this patch, and yes indeed, the problem was
> exactly that. Now honestly I cannot understand why this dependency
> with libpgport was not necessary before... In any case, attached is a
> patch rebased on HEAD that builds correctly with MSVC.

Now that the stuff related to the move from contrib/ to src/bin/,
modulescheck and tmp_install has been committed, shouldn't we give a
new shot at this patch? Attached is a rebased version.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [BUGS] Failure to coerce unknown type to specific type
Next
From: Heikki Linnakangas
Date:
Subject: Re: Moving ExecInsertIndexTuples and friends to new file