Re: Perf Benchmarking and regression. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Perf Benchmarking and regression.
Date
Msg-id CAB7nPqSuDGwsyFiU9BYfMRPHNm3+6at3thB6Bs6+qeU0YBen+g@mail.gmail.com
Whole thread Raw
In response to Re: Perf Benchmarking and regression.  (Andres Freund <andres@anarazel.de>)
Responses Re: Perf Benchmarking and regression.  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Fri, Jun 10, 2016 at 9:19 AM, Andres Freund <andres@anarazel.de> wrote:
> On 2016-06-09 14:37:31 -0700, Andres Freund wrote:
>> I'm writing a patch right now, planning to post it later today, commit
>> it tomorrow.
>
> Attached.

-        /* see bufmgr.h: OS dependent default */
-        DEFAULT_BACKEND_FLUSH_AFTER, 0, WRITEBACK_MAX_PENDING_FLUSHES,
+        0, 0, WRITEBACK_MAX_PENDING_FLUSHES,
Wouldn't it be better to still use LT_BACKEND_FLUSH_AFTER here, and
just enforce it to 0 for all the OSes at the top of bufmgr.h?
-- 
Michael



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Perf Benchmarking and regression.
Next
From: Andres Freund
Date:
Subject: Re: Perf Benchmarking and regression.