Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests
Date
Msg-id CAB7nPqSt+exL07fJYX0ntxuKJWY2VT8vdTqtnpJmiqA7G7Zu1Q@mail.gmail.com
Whole thread Raw
In response to Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Sep 9, 2016 at 1:25 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2016-09-08 20:15:46 -0400, Peter Eisentraut wrote:
>>> We don't support build directories with spaces in them, but we support
>>> installation directories with spaces in them.  So I guess that means
>>> your point is valid.
>
>> Even if not necessary in this specific case, I personally think it's
>> just a good to quote halfway sensibly. Especially when it's trivial to
>> do so.
>
> The problem is it's only halfway ... won't paths with quotes in them
> still break it?

Trying to build Postgres from source with top_srcdir containing a
quote already fails at ./configure... So I don't see a new problem
here but...
-- 
Michael



pgsql-hackers by date:

Previous
From: Kouhei Kaigai
Date:
Subject: Re: PassDownLimitBound for ForeignScan/CustomScan
Next
From: Alexander Korotkov
Date:
Subject: Re: PoC: Partial sort