Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidaeis *still* broken) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidaeis *still* broken)
Date
Msg-id CAB7nPqSrqKszjtnRc3YvKh7Pc1HJhtpaKW4gmeFM1QPcD2tSbg@mail.gmail.com
Whole thread Raw
In response to Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, soculicidae is *still* broken)  ("Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>)
Responses Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, soculicidae is *still* broken)  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Thu, May 25, 2017 at 11:34 AM, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> From: pgsql-hackers-owner@postgresql.org
>> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Noah Misch
>> Ten feels low to me.  The value should be be low enough so users don't give
>> up and assume a permanent hang, but there's little advantage to making it
>> lower.
>> I'd set it such that we give up in 1-5s on a modern Windows machine, which
>> I expect implies a retry count of one hundred or more.
>
> Then, maybe we can measure the time in each iteration and give up after a particular seconds.

Indeed, pgrename() does so with a 100ms sleep time between each
iteration. Perhaps we could do that and limit to 50 iterations?
-- 
Michael



pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, soculicidae is *still* broken)
Next
From: Noah Misch
Date:
Subject: Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, soculicidae is *still* broken)