Re: [HACKERS] Setting pd_lower in GIN metapage - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Setting pd_lower in GIN metapage
Date
Msg-id CAB7nPqSozeDujTf9q1nsk_Oz4E8xUfUC-YjJ22-0HVdhZqmT3A@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Setting pd_lower in GIN metapage  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] Setting pd_lower in GIN metapage
List pgsql-hackers
On Tue, Sep 19, 2017 at 12:57 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> I'd think about adjusting the comments the proper way for each AM so
> as one can read those comments and catch any limitation immediately.
> The fact this has not been pointed out on this thread before any
> checks and the many mails exchanged on the matter on this thread make
> me think that the current code does not outline the current code
> properties appropriately.

Another thing that we could consider as well is adding an assertion in
XLogRegisterBuffer & friends so as the combination of REGBUF_STANDARD
and REGBUF_NO_IMAGE is forbidden. That's bugging me as well.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Setting pd_lower in GIN metapage
Next
From: Vaishnavi Prabakaran
Date:
Subject: Re: [HACKERS] Simplify ACL handling for large objects and removal ofsuperuser() checks