Re: LSN as a recovery target - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: LSN as a recovery target
Date
Msg-id CAB7nPqSo5n2VNjivRiMC_4UKeJ7S4QJ23BS=rmKLLPXii8vq8Q@mail.gmail.com
Whole thread Raw
In response to Re: LSN as a recovery target  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: LSN as a recovery target  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Tue, Aug 23, 2016 at 6:10 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On 23 August 2016 at 09:39, Petr Jelinek <petr@2ndquadrant.com> wrote:
>
>> Looks very reasonable to me (both patches). Thanks for doing that.
>>
>> I am inclined to mark this as ready for committer.
>
> Looking at it now.
>
> The messages for recovery_target_lsn don't mention after or before, as
> do other targets... e.g.
>      recoveryStopAfter ? "after" : "before",
> My understanding is that if you request an LSN that isn't the exact
> end point of a WAL record then it will either stop before or after the
> requested point, so that needs to be described in the docs and in the
> messages generated prior to starting to search.
>
> Everything else looks in good order.

You are right, this message should be completed as such. Do you want
an updated patch?
-- 
Michael



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Block level parallel vacuum WIP
Next
From: Kevin Grittner
Date:
Subject: Re: Logical decoding of sequence advances, part II