Re: [HACKERS] Exclude pg_internal.init from base backup - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Exclude pg_internal.init from base backup
Date
Msg-id CAB7nPqSZnxwCrcS5vWE5R6_b+59H5+nj02oyff17oO-BXDKp2g@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Exclude pg_internal.init from base backup  (David Steele <david@pgmasters.net>)
List pgsql-hackers
On Wed, Nov 8, 2017 at 1:42 AM, David Steele <david@pgmasters.net> wrote:
> On 11/7/17 11:03 AM, Simon Riggs wrote:
>> On 5 November 2017 at 11:55, Magnus Hagander <magnus@hagander.net> wrote:
>>>
>>> So +1 for documenting the difference in how these are handled, as this is
>>> important to know for somebody writing an external tool for it.
>>
>> Changes made, moving to commit the attached patch.
>
> Thanks, Simon!  This was on my to do list today -- glad I checked my
> email first.
   <para>
+    <filename>pg_internal.init</filename> files can be omitted from the
+    backup whenever a file of that name is found.  These files contain
+    relation cache data that is always rebuilt when recovering.
+   </para>
Do we want to mention in the docs that the same decision-making is
done for *all* files with matching names, aka the fact that if a file
is listed and found in a sub-folder it is skipped? postmaster.opts or
similar friends are unlikely to be found in anything but the root of
the data folder, still the upthread argument of documenting precisely
what basebackup.c does sounded rather convincing to me.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Remove secondary checkpoint
Next
From: Nico Williams
Date:
Subject: Re: [HACKERS] MERGE SQL Statement for PG11