Re: pg_archivecleanup not deleting anything? - Mailing list pgsql-general

From Michael Paquier
Subject Re: pg_archivecleanup not deleting anything?
Date
Msg-id CAB7nPqSEokk3KiRq+9x4=-1Zchv5tBk1umyTc7Azz=aMzu8iOg@mail.gmail.com
Whole thread Raw
In response to Re: pg_archivecleanup not deleting anything?  (Albe Laurenz <laurenz.albe@wien.gv.at>)
Responses Re: pg_archivecleanup not deleting anything?
List pgsql-general
On Wed, Nov 4, 2015 at 7:16 PM, Albe Laurenz <laurenz.albe@wien.gv.at> wrote:
> Michael Paquier wrote:
>>>> The docs mention that "all WAL files" preceding a given point are
>>>> removed, personally I understand that as "all 16MB-size segments shall
>>>> die", hence excluding backup and history files from the stack. But one
>>>> may understand that "WAL files" means everything in pg_xlog, so as
>>>> something that includes backup and history files. Perhaps we would
>>>> gain in clarity by saying "WAL file segments, including .partial
>>>> segments" in the docs, and not just "WAL files". Thoughts?
>>>
>>> It might help to add:
>>> "Timeline history files and backup history files are not deleted."
>>
>> Something among those lines?
>
>> +  <para>
>> +   WAL file segments and WAL file segments with <literal>.partial</literal>
>> +   are deleted, while timeline history files and backup history files are not.
>> +  </para>
>
> "WAL file segments with .partial" sounds strange.
> What about "WAL file segments (including partial ones) are deleted, while ..."?

Does that look better?
--
Michael

Attachment

pgsql-general by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Deadlock detected after pg_repack receives SIGINT
Next
From: Jiří Hlinka
Date:
Subject: Re: Deadlock detected after pg_repack receives SIGINT