Re: [GENERAL] Retrieving query results - Mailing list pgsql-general

From Michael Paquier
Subject Re: [GENERAL] Retrieving query results
Date
Msg-id CAB7nPqSE5voeA5LTDZ6PLkA4jNWuYB7nJJTaXRJBREH2LJE2Fg@mail.gmail.com
Whole thread Raw
In response to Re: [GENERAL] Retrieving query results  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [GENERAL] Retrieving query results  (Igor Korot <ikorot01@gmail.com>)
Re: [GENERAL] Retrieving query results  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-general
On Thu, Aug 24, 2017 at 11:56 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I haven't tried it, but it sure looks like it would, if you don't hit
> OOM first.  pqAddTuple() isn't doing anything to guard against integer
> overflow.  The lack of reports implies that no one has ever tried to
> retrieve even 1G rows, let alone more ...

Yeah, looking at the code we would just need to check if ntups gets
negative (well, equal to INT_MIN) after being incremented.
--
Michael


pgsql-general by date:

Previous
From: Peter Hunčár
Date:
Subject: Re: [GENERAL] Multixact members limit exceeded
Next
From: Igor Korot
Date:
Subject: Re: [GENERAL] Retrieving query results