Re: [HACKERS] relkind check in DefineIndex - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] relkind check in DefineIndex
Date
Msg-id CAB7nPqS+tz8KsYFvMvhCAuopOsB1=Yh1V4hq2X5bwiCiOcJzoA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] relkind check in DefineIndex  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
On Mon, Oct 16, 2017 at 2:56 PM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> On 2017/10/14 4:32, Robert Haas wrote:
>> On Fri, Oct 13, 2017 at 12:38 PM, Alvaro Herrera
>> <alvherre@2ndquadrant.com> wrote:
>>> The relkind check in DefineIndex has grown into an ugly rats nest of
>>> 'if' statements.  I propose to change it into a switch, as per the
>>> attached.
>>
>> wfm
>
> +1

+1. There is as well CreateTrigger(), analyze_rel() or
ATRewriteCatalogs() that do similar things but those are not using
multiple layers of checks.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] [POC] hash partitioning
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] Determine state of cluster (HA)