Re: [PATCH] Support for pg_stat_archiver view - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Support for pg_stat_archiver view
Date
Msg-id CAB7nPqRz42LsC9X-u_iXVF-A1TE5WEBZrQk4+_3LNKTQw=-PNg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Support for pg_stat_archiver view  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: [PATCH] Support for pg_stat_archiver view  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Wed, Jan 29, 2014 at 10:55 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Wed, Jan 29, 2014 at 3:07 AM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
>>
>> Anybody knows about this patch?
>> http://www.postgresql.org/message-id/508DFEC9.4020102@uptime.jp
>
> Though I'm not sure whether Nagayasu is still working on that patch,
> it's worth thinking to introduce that together with pg_stat_archiver.
This patch uses globalStats to implement the new stat fields for
walwriter, I think that we should use a different structure for
clarity and to be in-line with what is done now with the archiver
part.

Btw, I agree that renaming the globalStats part to something more
appropriate related to bgwriter is a sane target for this CF, but
isn't it too late to late to consider this walwriter patch for this
release? It introduces a new feature as it tracks xlog dirty writes
and CF is already half way.
Regards,
-- 
Michael



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: [PATCH] Support for pg_stat_archiver view
Next
From: Tom Lane
Date:
Subject: Re: Suspicion of a compiler bug in clang: using ternary operator in ereport()