Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)
Date
Msg-id CAB7nPqRn+HCeC=w6Q9ofCPRO3um5yuAJJo9PHtNsxUTiNb0rLA@mail.gmail.com
Whole thread
In response to Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers


On Tue, Sep 30, 2014 at 12:06 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Sep 29, 2014 at 9:03 AM, Andres Freund <andres@2ndquadrant.com> wrote:
>> -        except that changes are returned as <type>bytea</type>.
>> +        except that changes are returned as <type>bytea</type> and that it
>> can
>> +        be used on slots using output plugins that only support binary
>> output.
>
> Imo that's pretty much implied because it references the !binary
> version. But I guess it doesn't hurt to be explicit. How about:
> " ... on output plugins using any form of output, including binary."?

I think you should just leave it alone.  There's no problem with what
it says there right now.  It goes without saying that if the plugin
can only return bytea, then you have to use the bytea-returning
function to get it.  If it's not clear that such plugins might exist,
that needs to be clarified better elsewhere, not here.
Yes, not modifying the current text would be fine.
--
Michael

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)
Next
From: Craig Ringer
Date:
Subject: Re: Fwd: Proper query implementation for Postgresql driver