Re: Commitfest: patches Ready for Committer - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Commitfest: patches Ready for Committer
Date
Msg-id CAB7nPqRhFW1PjjWzH+4Xtnop1vdUymEV=zS45uho6gxVVxnvJw@mail.gmail.com
Whole thread
In response to Re: Commitfest: patches Ready for Committer  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Mon, Oct 6, 2014 at 10:53 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
The levenshtein-distance thingy seems to still be a topic of debate
as well, both as to how we're going to refactor the code and as to
what the exact hinting rules ought to be.  If some committer wants
to take charge of it and resolve those issues, fine; but I don't want
to see it done by just blindly committing whatever the last submitted
version was.

My 2c. I imagine that in this case the consensus is going to be first:
- Move a minimum of the core functions of fuzzystrmatch and rename them (str_distance?)
- Do not dump fuzzystrmatch and have the levenshtein call those functions
In any case levenshtein code needs a careful refactoring and some additional thoughts first before the hint code is touched.
Regards.
--
Michael

pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Add regression tests for autocommit-off mode for psql and fix some omissions
Next
From: Michael Paquier
Date:
Subject: Re: Failure with make check-world for pgtypeslib/dt_test2 with HEAD on OSX