Re: Re[3]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Re[3]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
Date
Msg-id CAB7nPqRUJWh5j4BbUr2nnmjhzoPoZLhJ4TU8PrJ29SctBxO=9w@mail.gmail.com
Whole thread Raw
In response to Re[3]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code  (Alexey Vasiliev <leopard_ne@inbox.ru>)
Responses Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code  (Alexey Vasiliev <leopard_ne@inbox.ru>)
List pgsql-hackers
On Tue, Nov 4, 2014 at 6:25 AM, Alexey Vasiliev <leopard_ne@inbox.ru> wrote:
> Added new patch.
Seems useful to me to be able to tune this interval of time.

I would simply reword the documentation as follows:
If <varname>restore_command</> returns nonzero exit status code, retry
command after the interval of time specified by this parameter.
Default value is <literal>5s</>.

Also, I think that it would be a good idea to error out if this
parameter has a value of let's say, less than 1s instead of doing a
check for a positive value in the waiting latch. On top of that, the
default value of restore_command_retry_interval should be 5000 and not
0 to simplify the code.
-- 
Michael



pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: Proposal "VACUUM SCHEMA"
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Add transforms feature