Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype
Date
Msg-id CAB7nPqRThQHOxE53kavMfQy5iBoNspEd=TDvrsRX84asHA0K=Q@mail.gmail.com
Whole thread Raw
In response to Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers



On Sun, Feb 23, 2014 at 6:09 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
Michael Paquier escribió:
> Hi all,
>
> Please find attached a patch to dump pageinspect to 1.2. This simply
> changes page_header to use the new internal datatype pg_lsn instead of text.

Uhm.  Does this crash if you pg_upgrade a server that has 1.1 installed?
Oops yes you're right., it is obviously broken. Just re-thinking about that, dumping this module just to change an argument type does not seem to be worth the code complication. Thoughts?
Regards,
--
Michael

pgsql-hackers by date:

Previous
From: Mohsen SM
Date:
Subject: varchar_transform
Next
From: Andres Freund
Date:
Subject: Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype