Re: option -T in pg_basebackup doesn't work on windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: option -T in pg_basebackup doesn't work on windows
Date
Msg-id CAB7nPqRN3-CXLEPqk5CRMvwYQuXCvhxsDpt45e5AMhafsb-9fQ@mail.gmail.com
Whole thread Raw
In response to Re: option -T in pg_basebackup doesn't work on windows  ("MauMau" <maumau307@gmail.com>)
List pgsql-hackers
On Thu, Aug 14, 2014 at 12:50 AM, MauMau <maumau307@gmail.com> wrote:
> The code change appears correct, but the patch application failed against
> the latest source code.  I don't know why.  Could you confirm this?
>
> patching file src/bin/pg_basebackup/pg_basebackup.c
> Hunk #1 FAILED at 1119.
> 1 out of 1 hunk FAILED -- saving rejects to file
> src/bin/pg_basebackup/pg_basebackup.c.rej
This conflict is caused by f25e0bf.

> On the following line, I think %d must be %u, because Oid is an unsigned
> integer.
>  char    *linkloc = psprintf("%s/pg_tblspc/%d", basedir, oid);
That's correct.
-- 
Michael



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: jsonb format is pessimal for toast compression
Next
From: Michael Paquier
Date:
Subject: Re: replication commands and log_statements