Re: Optimization for updating foreign tables in Postgres FDW - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Optimization for updating foreign tables in Postgres FDW
Date
Msg-id CAB7nPqR1J7TUxPg6Fbw4bKNLPS1UCjq31uDp06r1HLj-c0TS-g@mail.gmail.com
Whole thread Raw
In response to Re: Optimization for updating foreign tables in Postgres FDW  (Thom Brown <thom@linux.com>)
Responses Re: Optimization for updating foreign tables in Postgres FDW
List pgsql-hackers
On Wed, Mar 23, 2016 at 10:05 PM, Thom Brown <thom@linux.com> wrote:
> I've noticed that you now can't cancel a query if there's DML pushdown
> to a foreign server.  This previously worked while it was sending
> individual statements as it interrupted and rolled it back.
>
> Here's what the local server sees when trying to cancel:
>
> # DELETE FROM remote.contacts;
> ^CCancel request sent
> DELETE 5000000
>
> This should probably be fixed.

Looking at what has been committed, execute_dml_stmt is using
PQexecParams, so we'd want to use an asynchronous call and loop on
PQgetResult with CHECK_FOR_INTERRUPTS() in it.
-- 
Michael



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Fix for OpenSSL error queue bug
Next
From: Fujii Masao
Date:
Subject: Re: Support for N synchronous standby servers - take 2