Re: Correction for replication slot creation error message in 9.6 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Correction for replication slot creation error message in 9.6
Date
Msg-id CAB7nPqQzppd=0K9u3UL8RwXfZbjUds+VmUcf1YJuD8rdKuVp+Q@mail.gmail.com
Whole thread Raw
In response to Re: Correction for replication slot creation error message in 9.6  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Correction for replication slot creation error message in 9.6  (Ian Barwick <ian@2ndquadrant.com>)
List pgsql-hackers
On Thu, Mar 31, 2016 at 11:18 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Andres Freund wrote:
>> On 2016-03-31 10:15:21 +0900, Ian Barwick wrote:
>
>> > Patch changes the error message to:
>> >
>> >   ERROR:  replication slots can only be used if wal_level is "replica" or "logical"
>> >
>> > Explicitly naming the valid WAL levels matches the wording in the wal_level
>> > error hint used in a couple of places, i.e.
>>
>> The explicit naming makes it much more verbose to change anything around
>> wal level though, so consider me not a fan of spelling out all levels.
>
> I thought we had agreed that we weren't going to consider the wal_level
> values as a linear scale -- in other words, wordings such as "greater
> than FOO" are discouraged.  That's always seemed a bit odd to me.

Yes, that's what I thought as well.
-- 
Michael



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: So, can we stop supporting Windows native now?
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH v9] GSSAPI encryption support