Postgres Pro
Downloads
Home   >   mailing lists

Re: BUG: *FF WALs under 9.2 (WAS: .ready files appearing on slaves) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: BUG: *FF WALs under 9.2 (WAS: .ready files appearing on slaves)
Date
Msg-id CAB7nPqQr2qUpL+yCYgbST4_5ZwAPjiLer-K-bngJa=m5=nxOvA@mail.gmail.com
Whole thread Raw
In response to Re: BUG: *FF WALs under 9.2 (WAS: .ready files appearing on slaves)  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view
On Thu, Oct 23, 2014 at 10:16 PM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Thu, Oct 23, 2014 at 1:45 PM, Heikki Linnakangas <hlinnakangas@vmware.com> wrote:
 That's not right. Should check *after* the write if the segment was completed, and close it if so. Like the attached.

Just tested this patch with the combo pg_switch_xlog() + stop/immediate and the apparition of the .ready files is not fixed.
Btw, I think that we should pass walEnd to XLogWalRcvWrite and add an additional check based on that after the write() loop calls to enforce the segment to be switched to .done.
--
Michael

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Typo fixes for pg_recvlogical documentation
Next
From: Andrew Dunstan
Date:
Subject: Re: idea: allow AS label inside ROW constructor