Postgres Pro
Downloads
Home   >   mailing lists

Making src/test/ssl more robust - Mailing list pgsql-hackers

From Michael Paquier
Subject Making src/test/ssl more robust
Date
Msg-id CAB7nPqQivFxnSjPwkyapa8=HTGm0hfDNvdGcM3=hkK6fPT0+Pg@mail.gmail.com
Whole thread Raw
Responses Re: Making src/test/ssl more robust
List pgsql-hackers
Tree view 
Hi all,

I noticed two things while looking at the SSL test suite:
1) When running the tests, some logs are generated in client-log, but
this log file has no entry in .gitignore... A patch is attached.
2) cp is used with a wildcard and system_or_bail in ServerSetup.pm:
  system_or_bail "cp ssl/server-*.crt '$tempdir'/pgdata";
  system_or_bail "cp ssl/server-*.key '$tempdir'/pgdata";
  system_or_bail "chmod 0600 '$tempdir'/pgdata/server-*.key";
  system_or_bail "cp ssl/root+client_ca.crt '$tempdir'/pgdata";
  system_or_bail "cp ssl/root+client.crl '$tempdir'/pgdata";
This does not look very portable to me. Wouldn't it be better to use
glob to get a list of the files and then copy each matching entry?
Thoughts?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Re: File count restriction of directory limits number of relations inside a database.
Next
From: Sawada Masahiko
Date:
Subject: Re: Proposal : REINDEX xxx VERBOSE