Re: [PATCH] add option to pg_dumpall to exclude tables from the dump - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] add option to pg_dumpall to exclude tables from the dump
Date
Msg-id CAB7nPqQeW-doEV1M0WjQ8wZQ-eNyRotpvyJEpPcMJwR7TeFZ+w@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] add option to pg_dumpall to exclude tables from the dump  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Sep 29, 2016 at 2:16 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Sep 6, 2016 at 9:37 PM, Gerdan Rezende dos Santos
> <gerdan@gmail.com> wrote:
>> After review, I realized that there is a call to the function:
>> doShellQuoting (pgdumpopts, OPTARG), which no longer seems to exist ...
>> After understand the code, I saw that the call is appendShellString
>> (pgdumpopts, OPTARG).
>>
>> Follow the patches already with the necessary corrections.
>
> This doesn't seem to take into account the discussion between Tom Lane
> and Jim Nasby about how this feature should work.

So, Juergen, it would be nice if you could participate in the
discussion and get a consensus on the patch. Until then, I am marking
this patch as returned with feedback.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Patch: Implement failover on libpq connect level.
Next
From: Thomas Munro
Date:
Subject: Re: [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation.