Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Removing #include "postgres.h" from a couple of headers - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Removing #include "postgres.h" from a couple of headers
Date
Msg-id CAB7nPqQdOUKjNa8dmsCy1+NrsxSa8a3ev5jjHe1hB8esyMo2rg@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Removing #include "postgres.h" from a couple of headers  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Tree view 
On Wed, Mar 8, 2017 at 5:55 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> Over in another thread it was pointed out that a patch I submitted
> broke a project rule by including "postgres.h" in a header.  Here is a
> patch to remove it from dsa.h where I made the same mistake, and also
> a case I found in bufmask.h by grepping.
>
> There are also instances in regcustom.h and snowball's header.h -- are
> those special cases?

--- a/src/include/access/bufmask.h
+++ b/src/include/access/bufmask.h
@@ -17,7 +17,6 @@#ifndef BUFMASK_H#define BUFMASK_H

-#include "postgres.h"#include "storage/block.h"#include "storage/bufmgr.h"
Oops. This really escaped me...
-- 
Michael

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: [HACKERS] Removing #include "postgres.h" from a couple of headers
Next
From: Kuntal Ghosh
Date:
Subject: Re: [HACKERS] WAL Consistency checking for hash indexes