Re: pg_regress writes into source tree - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_regress writes into source tree
Date
Msg-id CAB7nPqQ_HmwgxL+tC7ftjDxQt-dK2KyhtCzfj9uvi_8-z101JQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_regress writes into source tree  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pg_regress writes into source tree  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
List pgsql-hackers
On Sat, Feb 14, 2015 at 6:24 AM, Andrew Dunstan <andrew@dunslane.net> wrote:
>
> On 12/18/2014 06:05 PM, Andrew Dunstan wrote:
>>
>>
>> On 12/18/2014 03:02 AM, Michael Paquier wrote:
>>>
>>> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
>>> <alvherre@2ndquadrant.com> wrote:
>>>
>>>> Another thing in that patch was that I had to add the sql/ directory to
>>>> the source tree, but other than that .gitignore file it was empty.
>>>> Maybe pg_regress should create the sql/ directory in the build dir if it
>>>> doesn't exist.  This is only a problem if a pg_regress suite only runs
>>>> stuff from input/, because otherwise the sql/ dir already exists in the
>>>> source.
>>>
>>> +1 for having pg_regress create the sql/ directory when it does not
>>> exist. Current behavior is annoying when modules having only tests in
>>> input/...
>>
>>
>>
>>
>> That seems like a separate issue. I think Peter should commit his patch
>> and backpatch it immediately, and we can deal with the missing sql directory
>> when someone sends in a patch.
>
>
>
> What's happened on this?

Nothing has been committed, and as far as I understood this patch
could have been simply pushed...
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Strange assertion using VACOPT_FREEZE in vacuum.c
Next
From: Magnus Hagander
Date:
Subject: Re: New CF app deployment