Re: Issue with NULLS LAST, with postgres_fdw sort pushdown - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Issue with NULLS LAST, with postgres_fdw sort pushdown
Date
Msg-id CAB7nPqQZ=vs3HfubZGQK9p++9+x1p7-rO7S0Z1R=-WsQv2v_uQ@mail.gmail.com
Whole thread Raw
In response to Re: Issue with NULLS LAST, with postgres_fdw sort pushdown  (Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>)
Responses Re: Issue with NULLS LAST, with postgres_fdw sort pushdown
List pgsql-hackers
On Wed, Mar 2, 2016 at 7:04 PM, Rajkumar Raghuwanshi
<rajkumar.raghuwanshi@enterprisedb.com> wrote:
> On Wed, Mar 2, 2016 at 2:35 PM, Ashutosh Bapat
> <ashutosh.bapat@enterprisedb.com> wrote:
>>
>> Thanks Rajkumar for your report. Let me know if the attached patch fixes
>> the issue.
        if (pathkey->pk_nulls_first)            appendStringInfoString(buf, " NULLS FIRST");
+        else
+            appendStringInfoString(buf, " NULLS LAST");
Per explain.c, this looks inconsistent to me. Shouldn't NULLS LAST be
applied only if DESC is used in this ORDER BY clause?
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: The plan for FDW-based sharding
Next
From: Tatsuo Ishii
Date:
Subject: Re: The plan for FDW-based sharding