On Tue, Nov 21, 2017 at 4:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> The patch does not apply anymore and needs a rebase. There are also a
> bunch of whitespace errors, no documentation in the patch, and it
> seems to me that this patch introduces many concepts so it could be
> broken down into many individual steps. Finally, I strongly recommend
> that you review other's patches. You have two patches, including this
> one, registered into this commit fest but your name is showing nowhere
> as a reviewer. The patch you are proposing here is large, the usual
> recommendation being to review one patch of equal difficulty for each
> patch sent to keep the inflow and outflow of patches balanced.
With a high-level look, this patch requires a bit more work.. I am
unsure as well if that's a feature which would prove to be useful, but
without documentation it is hard to make an opinion of it. I am
marking the patch as returned with feedback.
--
Michael
