Re: [HACKERS] Autovacuum launcher occurs error when cancelled by SIGINT - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Autovacuum launcher occurs error when cancelled by SIGINT
Date
Msg-id CAB7nPqQMF45n5ZCVuGfuKfkj-z1bir3dU2qPg8yZUFHrGv2_8Q@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Autovacuum launcher occurs error when cancelled by SIGINT  (Yugo Nagata <nagata@sraoss.co.jp>)
Responses Re: [HACKERS] Autovacuum launcher occurs error when cancelled bySIGINT  (Yugo Nagata <nagata@sraoss.co.jp>)
List pgsql-hackers
On Wed, Jun 21, 2017 at 9:15 PM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
> This errors continue until this process is terminated or the server is restarted.
>
> When SIGINT is issued, the process exits from the main loop and returns
> to sigsetjmp, and calls dsa_attach() before entering into the loop again,
> this causes the error.
>
> We can fix it by calling dsa_attach() before sigsetjmp. Attached is the patch.

Your fix looks like a bad idea to me. If the shared memory area does
not exist after an exception occurred the process should be able to
re-attach to the shared memory area if it exists or create a new one
if that's not the case. That should not be a one-time execution.
-- 
Michael



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] pgrowlocks relkind check
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Autovacuum launcher occurs error when cancelled by SIGINT