Re: Adding in docs the meaning of pg_stat_replication.sync_state - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Adding in docs the meaning of pg_stat_replication.sync_state
Date
Msg-id CAB7nPqQLQa2B-P_JO_79m=mbG-PCTY1qo03p7eV1qQ31-4gytg@mail.gmail.com
Whole thread Raw
In response to Re: Adding in docs the meaning of pg_stat_replication.sync_state  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Adding in docs the meaning of pg_stat_replication.sync_state  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Tue, Dec 6, 2016 at 1:54 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> +           <literal>backup</>: The WAL sender is sending a backup.
>
> Seems it's better to use "This WAL sender" rather than "The WAL sender"
> like the descriptions of other fields.
>
> There are two descriptions of "streaming" value. You need to remove
> either of them.
>
> +           <literal>streaming</>: The WAL sender is catching up with the
> +           primary.
>
> "walsender is catching up with the primary" sounds a bit strange to me.
> What about "This WAL sender's connected standby server is catching up
> with the primary"?
>
> +           <literal>streaming</>: The WAL sender has caught up with the
> +           primary and is streaming changes.
>
> Same as above.

Agreed with all that. Attached is an updated version.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Adding in docs the meaning of pg_stat_replication.sync_state
Next
From: "David G. Johnston"
Date:
Subject: Re: Typmod associated with multi-row VALUES constructs